Ported to python3 using 2to3 script #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will make the code not back compatible. |
|
Hi Andrea, Sorry we were more focused on other stuff during the workshop. I'm not sure what you mean, I can only do PR to one existing branch, and I cannot request to create another one, right? Unless the question was not for me (that might be). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on the SMP-EFT combination and want to use the AnalyticAnomalousCoupling model with the latest combine version, so we need to port the code to python3. I've done this by using the 2to3 script as follows:
find . -name "*.py" -exec 2to3 -w -n -j 8 {} \;We could have a separate branch with this python3 version so it does not clash with the master.